cmake: convert x86* variants to x86 and x86_64#286
Conversation
|
can you rebase? Also for some reason CI didn't run |
1480c1
force-pushed
the
cmake/canonicalizex86
branch
from
c9a331d to
789a7ec
Compare
|
|
||
| IF(CPUINFO_SUPPORTED_PLATFORM) | ||
| IF(NOT CMAKE_SYSTEM_NAME STREQUAL "Emscripten" AND (CPUINFO_TARGET_PROCESSOR MATCHES "^(i[3-6]86|AMD64|x86(_64)?)$" OR IOS_ARCH MATCHES "^(i386|x86_64)$")) | ||
| IF(NOT CMAKE_SYSTEM_NAME STREQUAL "Emscripten" AND (CPUINFO_TARGET_PROCESSOR MATCHES "^x86(_64)?$" OR IOS_ARCH MATCHES "^(i386|x86_64)$")) |
There was a problem hiding this comment.
should i386 change for ios? seems like you could remove 32 bit x86 from ios simulator at this point?
There was a problem hiding this comment.
I don't think that is a decision I should make in this PR. It would be better if a separate PR is created so people who have an interest can comment on it.
fbarchard
left a comment
fbarchard
left a comment
There was a problem hiding this comment.
This change makes sense and looks good to me.
x86 and x86_64 are the common names used
would be good to rebase and land it
|
@1480c1 Can you rebase and run clang format? I should be able to merge after that. Thanks! |
This should reduce the number of checks for other variants like AMD64, amd64, etc. Signed-off-by: Christopher Degawa <ccom@randomderp.com>
1480c1
force-pushed
the
cmake/canonicalizex86
branch
from
789a7ec to
aa15ae3
Compare
I didn't touch any C/C++ files, so I don't think there's anything for me to run clang-format on. |
5 participants
This should reduce the number of checks for other variants like AMD64, amd64, etc.